topchetoeu/j2s
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases 74 Wiki Activity

fix: wrong precedences of && and ||

Browse Source 
(how the fuck did i get this wrong)
This commit is contained in:
TopchetoEU 2024-12-13 02:33:25 +02:00
parent 5346b8917d
commit c18015b9a0
Signed by: topchetoeu
GPG Key ID: 6531B8583E5F6ED4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/main/java/me/topchetoeu/jscript/compilation/values/operations/OperationNode.java
View File

@ -80,23 +80,23 @@ public class OperationNode extends Node {
} }
} }
private static class LazyAndFactory implements OperatorFactory { private static class LazyAndFactory implements OperatorFactory {
@Override public int precedence() { return 4; } @Override public int precedence() { return 5; }
@Override public String token() { return "&&"; } @Override public String token() { return "&&"; }
@Override public ParseRes<Node> construct(Source src, int i, Node prev) { @Override public ParseRes<Node> construct(Source src, int i, Node prev) {
var loc = src.loc(i); var loc = src.loc(i);
var other = JavaScript.parseExpression(src, i, 5); var other = JavaScript.parseExpression(src, i, 6);
if (!other.isSuccess()) return other.chainError(src.loc(i + other.n), "Expected a value after '&&'"); if (!other.isSuccess()) return other.chainError(src.loc(i + other.n), "Expected a value after '&&'");
return ParseRes.res(new LazyAndNode(loc, prev, (Node)other.result), other.n); return ParseRes.res(new LazyAndNode(loc, prev, (Node)other.result), other.n);
} }
} }
private static class LazyOrFactory implements OperatorFactory { private static class LazyOrFactory implements OperatorFactory {
@Override public int precedence() { return 5; } @Override public int precedence() { return 4; }
@Override public String token() { return "||"; } @Override public String token() { return "||"; }
@Override public ParseRes<Node> construct(Source src, int i, Node prev) { @Override public ParseRes<Node> construct(Source src, int i, Node prev) {
var loc = src.loc(i); var loc = src.loc(i);
var other = JavaScript.parseExpression(src, i, 6); var other = JavaScript.parseExpression(src, i, 5);
if (!other.isSuccess()) return other.chainError(src.loc(i + other.n), "Expected a value after '||'"); if (!other.isSuccess()) return other.chainError(src.loc(i + other.n), "Expected a value after '||'");
return ParseRes.res(new LazyOrNode(loc, prev, (Node)other.result), other.n); return ParseRes.res(new LazyOrNode(loc, prev, (Node)other.result), other.n);
} }